Enable strict concurrency #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Xcode 15 triggers concurrency warnings that are no longer triggered in Xcode 16 beta 3. |
PSchmiedmayer
approved these changes
Jul 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 90.69% 91.34% +0.66%
==========================================
Files 8 8
Lines 279 300 +21
==========================================
+ Hits 253 274 +21
Misses 26 26
Continue to review full report in Codecov by Sentry.
|
This was referenced Jul 15, 2024
Supereg
added a commit
that referenced
this pull request
Jul 15, 2024
# Lie to the Swift compiler about isolation ## ♻️ Current situation & Problem In PR #14 we truthfully implemented strict concurrency checking for the XCTRuntimeAssertions library. However, this made it impossible to test runtime precondition failures on the `@MainActor` as it would completely block the actor (or the Task would only be scheduled after the `XCTRuntimePrecondition` call returned). Therefore, it is necessary to always run `XCTRuntimePrecondition` expressions on a background thread. If we would keep correct `@Sendable` annotations for the expression closure, this would make it impossible to run `XCTRuntimePrecondition`s on the `@MainActor`. Therefore, we lie to the compiler. We deliberately don't annotate the expression closure as `@Sendable` and silence the respective concurrency warning. The impact of that is documented. ## ⚙️ Release Notes * Restore testing preconditions which are annotated to be isolated to the `@MainActor`. ## 📚 Documentation Add documentation bubbles to explain the impact. ## ✅ Testing Add unit testing to prevent regressions. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable strict concurrency
♻️ Current situation & Problem
This PR enables strict concurrency for the project and fixes resulting concurrency warnings.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: